Messages in this thread | | | Subject | Re: [RFC 04/32] parport: PC style parport depends on HAS_IOPORT | From | Niklas Schnelle <> | Date | Tue, 28 Dec 2021 15:21:37 +0100 |
| |
On Tue, 2021-12-28 at 11:14 +0100, Geert Uytterhoeven wrote: > Hi Niklas, > > On Mon, Dec 27, 2021 at 5:48 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote: > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > > not being declared. As PC style parport uses these functions we need to > > handle this dependency for HAS_IOPORT. > > > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > > Signed-off-by: Arnd Bergmann <arnd@kernel.org> > > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> > > Thanks for your patch! > > > --- a/drivers/parport/Kconfig > > +++ b/drivers/parport/Kconfig > > @@ -14,7 +14,6 @@ config ARCH_MIGHT_HAVE_PC_PARPORT > > > > menuconfig PARPORT > > tristate "Parallel port support" > > - depends on HAS_IOMEM > > Why drop this? > Don't all other parport drivers depend on it?
Seeing as the only platforms where HAS_IOMEM can even be unset are s390 and um you're probably right. Let's keep this.
> > > help > > If you want to use devices connected to your machine's parallel port > > (the connector at the computer with 25 holes), e.g. printer, ZIP > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
| |