| From | Geert Uytterhoeven <> | Date | Tue, 28 Dec 2021 11:17:00 +0100 | Subject | Re: [RFC 05/32] char: impi, tpm: depend on HAS_IOPORT |
| |
Hi Niklas,
Thanks for your patch!
On Mon, Dec 27, 2021 at 5:51 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add this dependency and ifdef > sections of code using inb()/outb() as alternative access methods. > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> > --- > drivers/char/Kconfig | 3 ++-
Your oneline-summary doesn't cover this file.
> drivers/char/ipmi/Makefile | 11 ++++------- > drivers/char/ipmi/ipmi_si_intf.c | 3 ++- > drivers/char/ipmi/ipmi_si_pci.c | 3 +++ > drivers/char/tpm/Kconfig | 1 + > drivers/char/tpm/tpm_infineon.c | 14 ++++++++++---- > drivers/char/tpm/tpm_tis_core.c | 19 ++++++++----------- > 7 files changed, 30 insertions(+), 24 deletions(-) > > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig > index 740811893c57..3d046e364e53 100644 > --- a/drivers/char/Kconfig > +++ b/drivers/char/Kconfig > @@ -33,6 +33,7 @@ config TTY_PRINTK_LEVEL > config PRINTER > tristate "Parallel printer support" > depends on PARPORT > + depends on HAS_IOPORT
Why? drivers/char/lp.c doesn't use I/O accessors, and should work with all parport drivers.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|