| From | Geert Uytterhoeven <> | Date | Tue, 28 Dec 2021 11:21:59 +0100 | Subject | Re: [RFC 10/32] i2c: Kconfig: add HAS_IOPORT dependencies |
| |
Hi Niklas,
On Mon, Dec 27, 2021 at 5:49 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
Thanks for your patch!
> --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -828,6 +828,7 @@ config I2C_NPCM7XX > > config I2C_OCORES > tristate "OpenCores I2C Controller" > + depends on HAS_IOPORT
While drivers/i2c/busses/i2c-ocores.c does use {in,out}(), I doubt this is used to access legacy I/O space.
> help > If you say yes to this option, support will be included for the > OpenCores I2C controller. For details see > @@ -1227,6 +1228,7 @@ config I2C_CP2615 > config I2C_PARPORT > tristate "Parallel port adapter" > depends on PARPORT > + depends on HAS_IOPORT
Same as PRINTER: shouldn't this work with all parport drivers?
> select I2C_ALGOBIT > select I2C_SMBUS > help
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|