Messages in this thread | | | Subject | Re: [RFC 03/32] ACPI: Kconfig: add HAS_IOPORT dependencies | From | Niklas Schnelle <> | Date | Mon, 27 Dec 2021 18:02:01 +0100 |
| |
On Mon, 2021-12-27 at 17:47 +0100, Rafael J. Wysocki wrote: > On Mon, Dec 27, 2021 at 5:44 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote: > > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > > not being declared. As ACPI always uses I/O port access > > The ARM64 people may not agree with this.
Maybe my wording is bad. This is my rewording of what Arnd had in his original mail: "The ACPI subsystem needs access to I/O ports, so that also gets a dependency."( https://lore.kernel.org/lkml/CAK8P3a0MNbx-iuzW_-=0ab6-TTZzwV-PT_6gAC1Gp5PgYyHcrA@mail.gmail.com/ ).
> > > we depend on HAS_IOPORT unconditionally. > > > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > > Signed-off-by: Arnd Bergmann <arnd@kernel.org> > > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> > > --- > > drivers/acpi/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > > index cdbdf68bd98f..b57f15817ede 100644 > > --- a/drivers/acpi/Kconfig > > +++ b/drivers/acpi/Kconfig > > @@ -9,6 +9,7 @@ config ARCH_SUPPORTS_ACPI > > menuconfig ACPI > > bool "ACPI (Advanced Configuration and Power Interface) Support" > > depends on ARCH_SUPPORTS_ACPI > > + depends on HAS_IOPORT > > select PNP > > select NLS > > default y if X86 > > -- > > 2.32.0 > >
| |