| Subject | Re: [PATCH v4 15/20] crypto: qce: Add new compatibles for qce crypto driver | From | Vladimir Zapolskiy <> | Date | Wed, 13 Oct 2021 22:22:09 +0300 |
| |
Hi Bhupesh,
On 10/13/21 1:55 PM, Bhupesh Sharma wrote: > Since we decided to use soc specific compatibles for describing > the qce crypto IP nodes in the device-trees, adapt the driver > now to handle the same. > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > drivers/crypto/qce/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > index 033c7278aa5d..2ab0b97d718c 100644 > --- a/drivers/crypto/qce/core.c > +++ b/drivers/crypto/qce/core.c > @@ -298,8 +298,8 @@ static int qce_crypto_remove(struct platform_device *pdev) > } > > static const struct of_device_id qce_crypto_of_match[] = { > - { .compatible = "qcom,crypto-v5.1", }, > - { .compatible = "qcom,crypto-v5.4", },
This breaks backward compatibility with old/not updated dtbs, I'm not sure, if that common rule has to be kept here, but at least it's worth to be mentioned.
> + { .compatible = "qcom,ipq6018-qce", }, > + { .compatible = "qcom,sdm845-qce", }, > {} > }; > MODULE_DEVICE_TABLE(of, qce_crypto_of_match); >
-- Best wishes, Vladimir
|