lkml.org 
[lkml]   [2021]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 05/20] dt-bindings: qcom-bam: Add 'interconnects' & 'interconnect-names' to optional properties
    From
    Date
    Hi Bhupesh,

    On 10/13/21 1:55 PM, Bhupesh Sharma wrote:
    > Add new optional properties - 'interconnects' and
    > 'interconnect-names' to the device-tree binding documentation for
    > qcom-bam DMA IP.
    >
    > These properties describe the interconnect path between bam and main
    > memory and the interconnect type respectively.
    >
    > Cc: Thara Gopinath <thara.gopinath@linaro.org>
    > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
    > Cc: Rob Herring <robh+dt@kernel.org>
    > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
    > ---
    > Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml | 8 ++++++++
    > 1 file changed, 8 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml
    > index 32b47e3b7769..602e68df971f 100644
    > --- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml
    > +++ b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml
    > @@ -45,6 +45,14 @@ properties:
    > const: 1
    > description: The single cell represents the channel index.
    >
    > + interconnects:
    > + maxItems: 1
    > + description: |

    here I have the same comment about the set literal style of the
    multi-line description, which is one-line, likely the specifier
    is not needed...

    > + Interconnect path between bam and main memory.
    > +
    > + interconnect-names:
    > + const: memory
    > +
    > qcom,ee:
    > $ref: /schemas/types.yaml#/definitions/uint32
    > description:
    >

    --
    Best wishes,
    Vladimir

    \
     
     \ /
      Last update: 2021-10-13 15:04    [W:4.103 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site