lkml.org 
[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 28/52] tools/perf/build: Split out feature check: 'on-exit'
Date
> diff --git a/tools/perf/config/feature-checks/test-on-exit.c b/tools/perf/config/feature-checks/test-on-exit.c
> new file mode 100644
> index 0000000..473f1de
> --- /dev/null
> +++ b/tools/perf/config/feature-checks/test-on-exit.c
> @@ -0,0 +1,6 @@
> +#include <stdio.h>
> +
> +int main(void)
> +{
> + return on_exit(NULL, NULL);
> +}

Just a nitpick. The manpage says the on_exit() requires <stdlib.h>
header rather than <stdio.h> and _BSD_SOURCE or _SVID_SOURCE defined.
So I think we can define _GNU_SOURCE before the header file or pass it
through make command line - it'd probably be better for synthesized
test-all.c checking.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-10-10 08:41    [W:0.371 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site