Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 32/52] tools/perf/build: Speed up auto-detection of features by adding a 'test-all' target | Date | Thu, 10 Oct 2013 17:28:21 +0900 |
| |
On Thu, 10 Oct 2013 09:24:13 +0200, Ingo Molnar wrote: > * Namhyung Kim <namhyung@kernel.org> wrote: > >> On Tue, 8 Oct 2013 12:11:02 +0200, Ingo Molnar wrote: >> > +test-all: >> > + $(BUILD) -Werror -fstack-protector -Wvolatile-register-var -O2 >> > -Werror -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lunwind -lunwind-x86_64 >> > -lelf -laudit -I/usr/include/slang -lslang $(shell pkg-config --libs >> > --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) >> > $(FLAGS_PYTHON_EMBED) -DPACKAGE='perf' -DPACKAGE=perf -lbfd -ldl >> >> Also missed -Wstack-protector. And duplicate -Werror. >> >> Anyway, it'd be great to generate this flags as well as source file >> automatically. > > Well, the source file would mean some extra construction overhead during > detection - but generating the flags ought to be possible, by putting the > test-all entry last and generating a rolling ALL_FLAGS variable via the > rules above it. > > Would you like to write such a patch?
Well, I'll try to do it tomorrow. :)
Thanks, Namhyung
| |