lkml.org 
[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 32/52] tools/perf/build: Speed up auto-detection of features by adding a 'test-all' target

* Namhyung Kim <namhyung@kernel.org> wrote:

> On Tue, 8 Oct 2013 12:11:02 +0200, Ingo Molnar wrote:
> > +test-all:
> > + $(BUILD) -Werror -fstack-protector -Wvolatile-register-var -O2
> > -Werror -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lunwind -lunwind-x86_64
> > -lelf -laudit -I/usr/include/slang -lslang $(shell pkg-config --libs
> > --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED)
> > $(FLAGS_PYTHON_EMBED) -DPACKAGE='perf' -DPACKAGE=perf -lbfd -ldl
>
> Also missed -Wstack-protector. And duplicate -Werror.
>
> Anyway, it'd be great to generate this flags as well as source file
> automatically.

Well, the source file would mean some extra construction overhead during
detection - but generating the flags ought to be possible, by putting the
test-all entry last and generating a rolling ALL_FLAGS variable via the
rules above it.

Would you like to write such a patch?

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-10-10 10:01    [W:0.342 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site