| From | Namhyung Kim <> | Subject | Re: [PATCH 02/52] tools/perf/build: Add feature check core code | Date | Thu, 10 Oct 2013 14:42:46 +0900 |
| |
Hi Ingo,
On Tue, 8 Oct 2013 12:10:32 +0200, Ingo Molnar wrote: > +feature_check = $(eval $(feature_check_code)); $(info CHK: config/feature-checks/test-$(1)) > +define feature_check_code > + feature-$(2) := $(shell make -C config/feature-checks test-$1 >/dev/null 2>/dev/null && echo 1 || echo 0) > +endef > + > +# > +# Build the feature check binaries in parallel, ignore errors, ignore return value and suppress output: > +# > +$(info Testing features:) > +$(shell make -i -j -C config/feature-checks >/dev/null 2>&1) > +$(info done) > + > +FEATURE_TESTS = hello > + > +$(foreach test,$(FEATURE_TESTS),$(call feature_check,$(test),$(test)))
So as far as I can see, all the feature checking goes twice - once in $(shell make ...) and another in $(foreach test,...). They look like doing exactly same thing. And the final Makefile in this series still has it twice. Is it intentional or did I miss something?
Thanks, Namhyung
|