| From | Namhyung Kim <> | Subject | Re: [PATCH 06/52] tools/perf/build: Split out feature check: 'stackprotector' | Date | Thu, 10 Oct 2013 14:50:11 +0900 |
| |
On Tue, 8 Oct 2013 12:10:36 +0200, Ingo Molnar wrote: > -ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -Wstack-protector,-Wstack-protector),y) > +ifeq ($(feature-stackprotector), 1) > CFLAGS += -Wstack-protector > endif
[SNIP]
> +test-stackprotector: > + $(BUILD) -Werror -fstack-protector
The flag being checked should be -"W"stack-protector instead of -"f"stack-protector. And the gcc manpage says that -Wstack-protector is only active when -fstack-protector is active. So the end result should look like
$(BUILD) -Werror -fstack-protector -Wstack-protector
Thanks, Namhyung
|