lkml.org 
[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 06/52] tools/perf/build: Split out feature check: 'stackprotector'
Date
On Tue,  8 Oct 2013 12:10:36 +0200, Ingo Molnar wrote:
> -ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -Wstack-protector,-Wstack-protector),y)
> +ifeq ($(feature-stackprotector), 1)
> CFLAGS += -Wstack-protector
> endif

[SNIP]

> +test-stackprotector:
> + $(BUILD) -Werror -fstack-protector

The flag being checked should be -"W"stack-protector instead of
-"f"stack-protector. And the gcc manpage says that -Wstack-protector is
only active when -fstack-protector is active. So the end result should
look like

$(BUILD) -Werror -fstack-protector -Wstack-protector

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-10-10 08:01    [W:0.314 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site