lkml.org 
[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] tools/perf/build: Improve the 'stackprotector' feature test
    Namhyung Kim noticed that the stackprotector testcase was incomplete:

    > The flag being checked should be -"W"stack-protector instead of
    > -"f"stack-protector. And the gcc manpage says that -Wstack-protector is
    > only active when -fstack-protector is active. So the end result should
    > look like
    >
    > $(BUILD) -Werror -fstack-protector -Wstack-protector

    Add -Wstack-protector.

    Reported-by: Namhyung Kim <namhyung@kernel.org>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    tools/perf/config/feature-checks/Makefile | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/config/feature-checks/Makefile b/tools/perf/config/feature-checks/Makefile
    index 2eb8346..c70d23e 100644
    --- a/tools/perf/config/feature-checks/Makefile
    +++ b/tools/perf/config/feature-checks/Makefile
    @@ -45,7 +45,7 @@ test-stackprotector-all:
    $(BUILD) -Werror -fstack-protector-all

    test-stackprotector:
    - $(BUILD) -Werror -fstack-protector
    + $(BUILD) -Werror -fstack-protector -Wstack-protector

    test-fortify-source:
    $(BUILD) -O2 -Werror -D_FORTIFY_SOURCE=2

    \
     
     \ /
      Last update: 2013-10-10 09:41    [W:2.744 / U:0.952 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site