lkml.org 
[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/52] tools/perf/build: Split out feature check: 'volatile-register-var'

    * Namhyung Kim <namhyung@kernel.org> wrote:

    > > +test-volatile-register-var:
    > > + $(BUILD) -Werror -Wvolatile-register-var
    >
    > I'm not sure this test is necessary at all.
    >
    > The gcc manpage says this warning is enabled by -Wall, and we add -Wall
    > to CFLAGS before doing feature checks. So all gcc versions that support
    > -Wvolatile-register-var enables it by default without this check and
    > older gcc versions will always fail the feature check.

    Good point - I'll send a patch to remove it.

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2013-10-10 10:21    [W:2.075 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site