Messages in this thread | | | Date | Thu, 10 Oct 2013 09:03:18 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 07/52] tools/perf/build: Split out feature check: 'volatile-register-var' |
| |
* Namhyung Kim <namhyung@kernel.org> wrote:
> > +test-volatile-register-var: > > + $(BUILD) -Werror -Wvolatile-register-var > > I'm not sure this test is necessary at all. > > The gcc manpage says this warning is enabled by -Wall, and we add -Wall > to CFLAGS before doing feature checks. So all gcc versions that support > -Wvolatile-register-var enables it by default without this check and > older gcc versions will always fail the feature check.
Good point - I'll send a patch to remove it.
Thanks,
Ingo
| |