Messages in this thread | | | Date | Wed, 9 Feb 2022 23:31:57 +0000 | From | Yazen Ghannam <> | Subject | Re: [PATCH v7 03/12] EDAC/mce_amd: Extract node id from MCA_IPID |
| |
On Thu, Feb 03, 2022 at 11:49:33AM -0600, Naveen Krishna Chatradhi wrote: > On SMCA banks of the GPU nodes, the node id information is > available in register MCA_IPID[47:44](InstanceIdHi). > > Convert the hardware node ID to a value used by Linux > where GPU nodes are sequentially after the CPU nodes. >
Terminology should be consistent. I see "node id" and "node ID" here.
...
> + } else if (bank_type == SMCA_UMC_V2) { > + /* > + * SMCA_UMC_V2 exists on GPU nodes, extract the node id > + * from register MCA_IPID[47:44](InstanceIdHi). > + * The InstanceIdHi field represents the instance ID of the GPU. > + * Which needs to be mapped to a value used by Linux, > + * where GPU nodes are simply numerically after the CPU nodes. > + */ > + node_id = amd_get_gpu_node_system_id(m->ipid);
As mentioned for the previous patch, why not define this function in EDAC?
Thanks, Yazen
| |