lkml.org 
[lkml]   [2022]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v7 06/12] EDAC/amd64: Add AMD heterogeneous family 19h Model 30h-3fh
On Thu, Feb 03, 2022 at 11:49:36AM -0600, Naveen Krishna Chatradhi wrote:
> From: Muralidhara M K <muralimk@amd.com>
>
> On heterogeneous systems with AMD CPUs, the data fabrics of the GPUs
> are connected directly via custom links.
>
> One such system, where Aldebaran GPU nodes are connected to the
> Family 19h, model 30h family of CPU nodes.
>
> Aldebaran GPU support was added to DRM framework
> https://lists.freedesktop.org/archives/amd-gfx/2021-February/059694.html
>

This message doesn't describe the patch.

> Signed-off-by: Muralidhara M K <muralimk@amd.com>
> Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
> ---
> Link:
> https://lkml.kernel.org/r/20211028130106.15701-6-nchatrad@amd.com
>
> v6->v7:
> * split the model specific assignments in patch 5 of v6 series
>
>
>
> drivers/edac/amd64_edac.c | 14 ++++++++++++++
> drivers/edac/amd64_edac.h | 2 ++
> 2 files changed, 16 insertions(+)
>
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index babd25f29845..54af7e38d26c 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -4454,6 +4454,19 @@ static void per_family_init(struct amd64_pvt *pvt)
> pvt->f0_id = PCI_DEVICE_ID_AMD_19H_M10H_DF_F0;
> pvt->f6_id = PCI_DEVICE_ID_AMD_19H_M10H_DF_F6;
> pvt->max_mcs = 2;
> + } else if (pvt->model >= 0x30 && pvt->model <= 0x3f) {
> + if (pvt->mc_node_id >= amd_nb_num()) {

"ALDEBARAN" is a specific device with unique PCI IDs. So this dependency on
amd_nb.c can be removed.

For example,
if (pvt->F3->device == PCI_DEVICE_ID_AMD_ALDEBARAN_DF_F3)
...

> + pvt->ctl_name = "ALDEBARAN";
> + pvt->f0_id = PCI_DEVICE_ID_AMD_ALDEBARAN_DF_F0;
> + pvt->f6_id = PCI_DEVICE_ID_AMD_ALDEBARAN_DF_F6;
> + pvt->max_mcs = 4;
> + goto end_fam;

Why not just "break" here instead of jumping to the break below?

> + } else {
> + pvt->ctl_name = "F19h_M30h";
> + pvt->f0_id = PCI_DEVICE_ID_AMD_19H_DF_F0;
> + pvt->f6_id = PCI_DEVICE_ID_AMD_19H_DF_F6;
> + pvt->max_mcs = 8;
> + }
> } else {
> pvt->ctl_name = "F19h";
> pvt->f0_id = PCI_DEVICE_ID_AMD_19H_DF_F0;
> @@ -4476,6 +4489,7 @@ static void per_family_init(struct amd64_pvt *pvt)
> pvt->ops->get_mc_regs = __read_mc_regs_df;
> pvt->ops->populate_csrows = init_csrows_df;
> pvt->ops->get_umc_err_info = update_umc_err_info;
> + end_fam:
> break;
>
> default:

Thanks,
Yazen

\
 
 \ /
  Last update: 2022-02-15 17:40    [W:0.118 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site