Messages in this thread | | | Date | Tue, 15 Feb 2022 15:49:25 +0000 | From | Yazen Ghannam <> | Subject | Re: [PATCH v7 05/12] EDAC/amd64: Define dynamic family ops routines |
| |
On Thu, Feb 03, 2022 at 11:49:35AM -0600, Naveen Krishna Chatradhi wrote: > From: Muralidhara M K <muralimk@amd.com> > > Extending family-specific assignments dynamic.
The commit message doesn't clearly describe what the patch is about.
> This would simplify adding support for future platforms. > > Signed-off-by: Muralidhara M K <muralimk@amd.com> > Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com> > ---
...
> --- a/drivers/edac/amd64_edac.h > +++ b/drivers/edac/amd64_edac.h > @@ -481,6 +481,19 @@ struct low_ops { > struct err_info *err); > int (*dbam_to_cs)(struct amd64_pvt *pvt, u8 dct, > unsigned int cs_mode, int cs_mask_nr); > + void (*prep_chip_selects)(struct amd64_pvt *pvt); > + void (*determine_memory_type)(struct amd64_pvt *pvt); > + void (*determine_ecc_sym_sz)(struct amd64_pvt *pvt); > + bool (*ecc_enabled)(struct amd64_pvt *pvt); > + void (*determine_edac_ctl_cap)(struct mem_ctl_info *mci, struct amd64_pvt *pvt); > + unsigned long (*determine_edac_cap)(struct amd64_pvt *pvt); > + int (*get_cs_mode)(int dimm, u8 ctrl, struct amd64_pvt *pvt); > + void (*get_base_mask)(struct amd64_pvt *pvt); > + void (*dump_misc_regs)(struct amd64_pvt *pvt); > + void (*get_mc_regs)(struct amd64_pvt *pvt); > + void (*setup_mci_misc_attrs)(struct mem_ctl_info *mci); > + int (*populate_csrows)(struct mem_ctl_info *mci); > + void (*get_umc_err_info)(struct mce *m, struct err_info *err); > };
I think there should be a patch for breaking out each of these functions.
Thanks, Yazen
| |