lkml.org 
[lkml]   [2021]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 19/46] mm/migrate: Add folio_migrate_flags()
>  	/*
> * Please do not reorder this without considering how mm/ksm.c's
> * get_ksm_page() depends upon ksm_migrate_page() and PageSwapCache().
> */
> - if (PageSwapCache(page))
> - ClearPageSwapCache(page);
> - ClearPagePrivate(page);
> - set_page_private(page, 0);
> + if (folio_swapcache(folio))
> + folio_clear_swapcache_flag(folio);
> + folio_clear_private_flag(folio);
> +
> + /* page->private contains hugetlb specific flags */
> + if (!folio_hugetlb(folio))
> + folio->private = NULL;

Ymmm. Dosn't the ->private handling change now? Given that you
added a comment it seems intentional, but I do not understand why
it changes as part of the conversion.

\
 
 \ /
  Last update: 2021-06-23 10:33    [W:0.971 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site