Messages in this thread | | | Date | Thu, 24 Jun 2021 18:37:47 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH v2 17/46] mm/memcg: Convert mem_cgroup_track_foreign_dirty_slowpath() to folio |
| |
On Wed, Jun 23, 2021 at 10:21:26AM +0200, Christoph Hellwig wrote: > Looks good, > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > Although I wish we could come up with a shorter name for > mem_cgroup_track_foreign_dirty_slowpath somehow..
It is quite grotesque!
How about folio_track_foreign_writeback() as a replacement name for mem_cgroup_track_foreign_dirty() and have it call __folio_track_foreign_writeback()?
Although 'foreign' tends to be used in MM to mean "wrong NUMA node", so maybe that's misleading. folio_track_dirty_cgroup()? folio_mark_dirty_cgroup()? (the last to be read in context of __set_page_dirty() being renamed to __folio_mark_dirty())
| |