lkml.org 
[lkml]   [2021]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 14/46] mm/memcg: Add folio_charge_cgroup()
On Thu 24-06-21 17:42:58, Matthew Wilcox wrote:
> On Wed, Jun 23, 2021 at 10:15:20AM +0200, Christoph Hellwig wrote:
> > On Tue, Jun 22, 2021 at 01:15:19PM +0100, Matthew Wilcox (Oracle) wrote:
> > > mem_cgroup_charge() already assumed it was being passed a non-tail
> > > page (and looking at the callers, that's true; it's called for freshly
> > > allocated pages). The only real change here is that folio_nr_pages()
> > > doesn't compile away like thp_nr_pages() does as folio support
> > > is not conditional on transparent hugepage support. Reimplement
> > > mem_cgroup_charge() as a wrapper around folio_charge_cgroup().
> >
> > Maybe rename __mem_cgroup_charge to __folio_charge_cgroup as well?
>
> Oh, yeah, should have done that. Thanks.

I would stick with __mem_cgroup_charge here. Not that I would insist but the
folio nature is quite obvious from the parameter already.

Btw. memcg_check_events doesn't really need the page argument. A nid
should be sufficient and your earlier patch is already touching the
softlimit code so maybe it would be worth changing this page -> folio ->
page back and forth.

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2021-06-25 10:22    [W:0.112 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site