lkml.org 
[lkml]   [2021]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 25/46] mm/writeback: Add folio_start_writeback()
    On Wed, Jun 23, 2021 at 11:18:04AM +0200, Christoph Hellwig wrote:
    > > +static inline void set_page_writeback_keepwrite(struct page *page)
    > > {
    > > + folio_start_writeback_keepwrite(page_folio(page));
    > > }
    > >
    > > +static inline bool test_set_page_writeback(struct page *page)
    > > {
    > > + return set_page_writeback(page);
    > > }
    >
    > Shouldn't these be in folio-compat.c as well?

    Thought about it. We only have one caller of
    set_page_writeback_keepwrite(), so it may as well get inlined there.
    And test_set_page_writeback() is just a renaming ... I'd rather
    replace the callers of test_set_page_writeback() with calls to
    the new set_page_writeback() than move it into folio-compat.

    > Otherwise looks good:
    >
    > Reviewed-by: Christoph Hellwig <hch@lst.de>

    \
     
     \ /
      Last update: 2021-06-24 20:34    [W:2.311 / U:1.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site