| Date | Wed, 23 Jun 2021 11:27:12 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 27/46] mm/writeback: Add __folio_mark_dirty() |
| |
On Tue, Jun 22, 2021 at 01:15:32PM +0100, Matthew Wilcox (Oracle) wrote: > Turn __set_page_dirty() into a wrapper around __folio_mark_dirty() (which > can directly cast from page to folio because we know that set_page_dirty() > calls filesystems with the head page). Convert account_page_dirtied() > into folio_account_dirtied() and account the number of pages in the folio.
Is it really worth micro-optimizing a transitional function like that? I'd rather eat the overhead of the compound_page() call over adding hacky casts like this.
|