Messages in this thread | | | Date | Wed, 23 Jun 2021 11:50:04 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 36/46] mm/filemap: Add readahead_folio() |
| |
On Tue, Jun 22, 2021 at 01:15:41PM +0100, Matthew Wilcox (Oracle) wrote: > The pointers stored in the page cache are folios, by definition. > This change comes with a behaviour change -- callers of readahead_folio() > are no longer required to put the page reference themselves. This matches > how readpage works, rather than matching how readpages used to work.
The way this stores and retrieves different but compatible types from the same xarray is a little nasty. But I guess we'll have to live with it for now, so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |