Messages in this thread | | | Date | Sat, 13 Nov 2021 14:02:14 -0600 | From | Bjorn Andersson <> | Subject | Re: [PATCH v5 09/22] dt-bindings: qcom-qce: Move 'clocks' to optional properties |
| |
On Wed 10 Nov 04:59 CST 2021, Bhupesh Sharma wrote:
> QCom QCE block on some SoCs like ipq6018 don't > require clock as the required property, so the properties > 'clocks' and 'clock-names' can be moved instead in the dt-bindings > to the 'optional' properties section. > > Otherwise, running 'make dtbs_check' leads to the following > errors: > > dma-controller@7984000: clock-names:0: 'bam_clk' was expected > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > dma-controller@7984000: clock-names: Additional items are not allowed ('bam_clk' was unexpected) > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > dma-controller@7984000: clock-names: ['iface_clk', 'bam_clk'] is too long > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > dma-controller@7984000: clocks: [[9, 138], [9, 137]] is too long > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > index 30deaa0fa93d..f35bdb9ee7a8 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > @@ -53,8 +53,6 @@ properties: > required: > - compatible > - reg > - - clocks > - - clock-names
I would prefer that we make this conditional on the compatible. That said, if this only applies to ipq6018 I think we should double check the fact that there's no clock there...
For the sake of making progress on the series, I think you should omit this patch from the next version.
Regards, Bjorn
> - dmas > - dma-names > > -- > 2.31.1 >
| |