lkml.org 
[lkml]   [2021]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v5 10/22] dt-bindings: qcom-qce: Add 'iommus' to optional properties
On Wed 10 Nov 04:59 CST 2021, Bhupesh Sharma wrote:

> Add the missing optional property - 'iommus' to the
> device-tree binding documentation for qcom-qce crypto IP.
>
> This property describes the phandle(s) to apps_smmu node with sid mask.

"This property describes the iommu streams for crypto pipes" or
something along those lines - depending on what those streams actually
represent.

>
> Cc: Thara Gopinath <thara.gopinath@linaro.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> .../devicetree/bindings/crypto/qcom-qce.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> index f35bdb9ee7a8..efe349e66ae7 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> @@ -32,6 +32,12 @@ properties:
> - const: bus
> - const: core
>
> + iommus:
> + minItems: 1
> + maxItems: 8
> + description: |

No need for the '|' here...

> + phandle to apps_smmu node with sid mask.
> +
> interconnects:
> maxItems: 1
> description:
> @@ -70,4 +76,9 @@ examples:
> clock-names = "iface", "bus", "core";
> dmas = <&cryptobam 2>, <&cryptobam 3>;
> dma-names = "rx", "tx";
> + iommus = <&apps_smmu 0x584 0x0011>,
> + <&apps_smmu 0x586 0x0011>,
> + <&apps_smmu 0x594 0x0011>,
> + <&apps_smmu 0x596 0x0011>;
> +

Extra empty line here.

Regards,
Bjorn

> };
> --
> 2.31.1
>
\
 
 \ /
  Last update: 2021-11-13 22:24    [W:0.355 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site