lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 17/22] crypto: qce: Print a failure msg in case probe() fails
    On Wed 10 Nov 04:59 CST 2021, Bhupesh Sharma wrote:

    > Print a failure message (dev_err) in case the qcom qce crypto
    > driver probe() fails.
    >
    > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
    > Cc: Rob Herring <robh+dt@kernel.org>
    > Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>
    > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
    > ---
    > drivers/crypto/qce/core.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
    > index 98784d63d78c..7c90401a2ef1 100644
    > --- a/drivers/crypto/qce/core.c
    > +++ b/drivers/crypto/qce/core.c
    > @@ -280,6 +280,7 @@ static int qce_crypto_probe(struct platform_device *pdev)
    > err_mem_path_disable:
    > icc_set_bw(qce->mem_path, 0, 0);
    > err:
    > + dev_err(dev, "%s failed : %d\n", __func__, ret);

    There's two possible outcomes of this style of error logging:

    1) You came through a code path with a specific error message, so you
    will have something that will say:

    qce: Some useful error text
    qce: qce_crypto_probe failed: -22

    2) You came through a code path without a specific error message:

    qce: qce_crypto_probe failed: -22


    In the first case the second line is just pure spam, in the second case
    the bare -22 is typically completely useless - given that there tend to
    be just a few commonly used errno values coming from multiple possible
    error sources.

    As such, no thanks. If you have an error case in qce_crypto_probe() that
    doesn't have a good, useful, error message, please fix that.

    Regards,
    Bjorn

    > return ret;
    > }
    >
    > --
    > 2.31.1
    >

    \
     
     \ /
      Last update: 2021-11-16 00:26    [W:4.571 / U:0.684 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site