Messages in this thread | | | Subject | Re: [PATCH v5 11/22] dt-bindings: crypto : Add new compatible strings for qcom-qce | From | Vladimir Zapolskiy <> | Date | Fri, 12 Nov 2021 12:25:13 +0200 |
| |
Hi Bhupesh,
On 11/10/21 12:59 PM, Bhupesh Sharma wrote: > Newer qcom chips support newer versions of the qce crypto IP, so add > soc specific compatible strings for qcom-qce instead of using crypto > IP version specific ones. > > Keep the old strings for backward-compatibility, but mark them as > deprecated. > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > index efe349e66ae7..77b9f544f32f 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml > @@ -15,7 +15,13 @@ description: | > > properties: > compatible: > - const: qcom,crypto-v5.1 > + enum: > + - qcom,crypto-v5.1 # Deprecated. Kept only for backward compatibility > + - qcom,ipq6018-qce > + - qcom,sdm845-qce > + - qcom,sm8150-qce > + - qcom,sm8250-qce > + - qcom,sm8350-qce
let me ask you to add at least two more compatibles to the list: qcom,ipq8074-qce and qcom,msm8996-qce.
> > reg: > maxItems: 1 > @@ -68,7 +74,7 @@ examples: > - | > #include <dt-bindings/clock/qcom,gcc-apq8084.h> > crypto-engine@fd45a000 { > - compatible = "qcom,crypto-v5.1"; > + compatible = "qcom,ipq6018-qce"; > reg = <0xfd45a000 0x6000>; > clocks = <&gcc GCC_CE2_AHB_CLK>, > <&gcc GCC_CE2_AXI_CLK>, >
-- Best wishes, Vladimir
| |