| From | Chen-Yu Tsai <> | Date | Mon, 5 Aug 2019 11:35:05 +0800 | Subject | Re: [PATCH v6 02/57] bus: sunxi-rsb: Remove dev_err() usage after platform_get_irq() |
| |
Hi,
On Wed, Jul 31, 2019 at 2:16 AM Stephen Boyd <swboyd@chromium.org> wrote: > > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. > > // <smpl> > @@ > expression ret; > struct platform_device *E; > @@ > > ret = > ( > platform_get_irq(E, ...) > | > platform_get_irq_byname(E, ...) > ); > > if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > -if (ret != -EPROBE_DEFER) > -{ ... > -dev_err(...); > -... } > | > ... > -dev_err(...); > ) > ... > } > // </smpl> > > While we're here, remove braces on if statements that only have one > statement (manually). > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > Cc: Chen-Yu Tsai <wens@csie.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > > Please apply directly to subsystem trees
I didn't follow this series. Is this for -fixes or -next?
Thanks.
> drivers/bus/sunxi-rsb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c > index 1b76d9585902..be79d6c6a4e4 100644 > --- a/drivers/bus/sunxi-rsb.c > +++ b/drivers/bus/sunxi-rsb.c > @@ -651,10 +651,8 @@ static int sunxi_rsb_probe(struct platform_device *pdev) > return PTR_ERR(rsb->regs); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "failed to retrieve irq: %d\n", irq); > + if (irq < 0) > return irq; > - } > > rsb->clk = devm_clk_get(dev, NULL); > if (IS_ERR(rsb->clk)) { > -- > Sent by a computer through tubes >
|