| Subject | Re: [PATCH v6 11/57] edac: Remove dev_err() usage after platform_get_irq() | From | James Morse <> | Date | Fri, 2 Aug 2019 18:04:16 +0100 |
| |
Hi,
On 30/07/2019 19:15, Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong.
I assume this is part of a series that makes this the case...
> Let's remove these prints with a simple semantic patch. > > // <smpl> > @@ > expression ret; > struct platform_device *E; > @@ > > ret = > ( > platform_get_irq(E, ...) > | > platform_get_irq_byname(E, ...) > ); > > if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > -if (ret != -EPROBE_DEFER) > -{ ... > -dev_err(...); > -... } > | > ... > -dev_err(...); > ) > ... > } > // </smpl>
> While we're here, remove braces on if statements that only have one > statement (manually).
Reviewed-by: James Morse <james.morse@arm.com>
Thanks,
James
|