| From | Paul Burton <> | Subject | Re: [PATCH v6 08/57] MIPS: Remove dev_err() usage after platform_get_irq() | Date | Mon, 26 Aug 2019 11:05:29 +0000 |
| |
Hello,
Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. > > // <smpl> > @@ > expression ret; > struct platform_device *E; > @@ > > ret = > ( > platform_get_irq(E, ...) > | > platform_get_irq_byname(E, ...) > ); > > if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > -if (ret != -EPROBE_DEFER) > -{ ... > -dev_err(...); > -... } > | > ... > -dev_err(...); > ) > ... > } > // </smpl> > > While we're here, remove braces on if statements that only have one > statement (manually).
Applied to mips-next.
> commit 322e577b02ab > https://git.kernel.org/mips/c/322e577b02ab > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Paul Burton <paul.burton@mips.com>
Thanks, Paul
[ This message was auto-generated; if you believe anything is incorrect then please email paul.burton@mips.com to report it. ]
|