| Subject | Re: [PATCH v6 19/57] iio: Remove dev_err() usage after platform_get_irq() | From | Phil Reid <> | Date | Wed, 31 Jul 2019 14:42:16 +0800 |
| |
G'day Stephen,
A comment unrelated to your change.
On 31/07/2019 02:15, Stephen Boyd wrote: ....
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 32f1c4a33b20..abe99856c823 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -1179,10 +1179,8 @@ static int at91_adc_probe(struct platform_device *pdev) > idev->info = &at91_adc_info; > > st->irq = platform_get_irq(pdev, 0); > - if (st->irq < 0) { > - dev_err(&pdev->dev, "No IRQ ID is designated\n"); > + if (st->irq < 0) > return -ENODEV; Should this be returning st->irq instead of -ENODEV? eg: platform_get_irq can return -EPROBE_DEFER
Pattern is repeated in a number of other places.
> - } > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > Regards Phil Reid
|