lkml.org 
[lkml]   [2019]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH v6 19/57] iio: Remove dev_err() usage after platform_get_irq()
From
Date
G'day Stephen,

A comment unrelated to your change.

On 31/07/2019 02:15, Stephen Boyd wrote:
....

> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 32f1c4a33b20..abe99856c823 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -1179,10 +1179,8 @@ static int at91_adc_probe(struct platform_device *pdev)
> idev->info = &at91_adc_info;
>
> st->irq = platform_get_irq(pdev, 0);
> - if (st->irq < 0) {
> - dev_err(&pdev->dev, "No IRQ ID is designated\n");
> + if (st->irq < 0)
> return -ENODEV;
Should this be returning st->irq instead of -ENODEV?
eg: platform_get_irq can return -EPROBE_DEFER

Pattern is repeated in a number of other places.


> - }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
Regards
Phil Reid

\
 
 \ /
  Last update: 2019-07-31 08:42    [W:0.909 / U:1.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site