lkml.org 
[lkml]   [2019]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 03/57] hwrng: Remove dev_err() usage after platform_get_irq()
    On Tue, Jul 30, 2019 at 11:15:03AM -0700, Stephen Boyd wrote:
    > We don't need dev_err() messages when platform_get_irq() fails now that
    > platform_get_irq() prints an error message itself when something goes
    > wrong. Let's remove these prints with a simple semantic patch.
    >
    > // <smpl>
    > @@
    > expression ret;
    > struct platform_device *E;
    > @@
    >
    > ret =
    > (
    > platform_get_irq(E, ...)
    > |
    > platform_get_irq_byname(E, ...)
    > );
    >
    > if ( \( ret < 0 \| ret <= 0 \) )
    > {
    > (
    > -if (ret != -EPROBE_DEFER)
    > -{ ...
    > -dev_err(...);
    > -... }
    > |
    > ...
    > -dev_err(...);
    > )
    > ...
    > }
    > // </smpl>
    >
    > While we're here, remove braces on if statements that only have one
    > statement (manually).
    >
    > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Cc: Matt Mackall <mpm@selenic.com>
    > Cc: Herbert Xu <herbert@gondor.apana.org.au>
    > Signed-off-by: Stephen Boyd <swboyd@chromium.org>

    Please resend via linux-crypto. Thanks.
    --
    Email: Herbert Xu <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

    \
     
     \ /
      Last update: 2019-08-09 08:18    [W:2.369 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site