Messages in this thread | | | Date | Fri, 9 Aug 2019 16:17:40 +1000 | From | Herbert Xu <> | Subject | Re: [PATCH v6 03/57] hwrng: Remove dev_err() usage after platform_get_irq() |
| |
On Tue, Jul 30, 2019 at 11:15:03AM -0700, Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. > > // <smpl> > @@ > expression ret; > struct platform_device *E; > @@ > > ret = > ( > platform_get_irq(E, ...) > | > platform_get_irq_byname(E, ...) > ); > > if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > -if (ret != -EPROBE_DEFER) > -{ ... > -dev_err(...); > -... } > | > ... > -dev_err(...); > ) > ... > } > // </smpl> > > While we're here, remove braces on if statements that only have one > statement (manually). > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Matt Mackall <mpm@selenic.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Please resend via linux-crypto. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |