| Date | Wed, 31 Jul 2019 20:58:02 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH v6 10/57] dmaengine: Remove dev_err() usage after platform_get_irq() |
| |
On 30-07-19, 11:15, Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. > > // <smpl> > @@ > expression ret; > struct platform_device *E; > @@ > > ret = > ( > platform_get_irq(E, ...) > | > platform_get_irq_byname(E, ...) > ); > > if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > -if (ret != -EPROBE_DEFER) > -{ ... > -dev_err(...); > -... } > | > ... > -dev_err(...); > ) > ... > } > // </smpl> > > While we're here, remove braces on if statements that only have one > statement (manually).
I would have preferred a patch per driver, but that does become insane for treewide work, so I am taking this as is
Applied, thanks
-- ~Vinod
|