| Date | Thu, 6 Feb 2014 19:41:03 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 01/51] CPU hotplug: Provide lockless versions of callback registration functions |
| |
On 02/06, Srivatsa S. Bhat wrote: > > The following method of CPU hotplug callback registration is not safe > due to the possibility of an ABBA deadlock involving the cpu_add_remove_lock > and the cpu_hotplug.lock.
Off-topic, but perhaps it also makes sense to add the lockdep annotations later, to catch other similar problems. Currently get_online_cpus() acquires nothing from lockdep pov.
As for the this patch/series, personally I agree.
Oleg.
|