Messages in this thread | | | Date | Thu, 06 Feb 2014 21:19:50 -0800 (PST) | Subject | Re: [PATCH 50/51] net/core/flow.c: Fix CPU hotplug callback registration | From | David Miller <> |
| |
From: David Miller <davem@davemloft.net> Date: Thu, 06 Feb 2014 20:39:21 -0800 (PST)
> From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> > Date: Thu, 06 Feb 2014 03:43:46 +0530 > >> Subsystems that want to register CPU hotplug callbacks, as well as perform >> initialization for the CPUs that are already online, often do it as shown >> below: > ... >> This is wrong, since it is prone to ABBA deadlocks involving the >> cpu_add_remove_lock and the cpu_hotplug.lock (when running concurrently >> with CPU hotplug operations). >> >> Instead, the correct and race-free way of performing the callback >> registration is: > ... >> Fix the code in net/core/flow.c by using this latter form of callback >> registration. >> >> Cc: "David S. Miller" <davem@davemloft.net> >> Cc: Li RongQing <roy.qing.li@gmail.com> >> Cc: Sasha Levin <sasha.levin@oracle.com> >> Cc: Andrew Morton <akpm@linux-foundation.org> >> Cc: Chris Metcalf <cmetcalf@tilera.com> >> Cc: netdev@vger.kernel.org >> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> > > Applied.
I just realized that this has a dependency not in the 'net' tree, so I reverted and assume you will merge this with the patch that provides the necessary interface(s).
Signed-off-by: David S. Miller <davem@davemloft.net>
| |