lkml.org 
[lkml]   [2014]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 29/51] arm64, debug-monitors: Fix CPU hotplug callback registration
    On Wed, Feb 05, 2014 at 10:09:58PM +0000, Srivatsa S. Bhat wrote:
    > Subsystems that want to register CPU hotplug callbacks, as well as perform
    > initialization for the CPUs that are already online, often do it as shown
    > below:

    [...]

    > Fix the debug-monitors code in arm64 by using this latter form of callback
    > registration.
    >
    > Cc: Catalin Marinas <catalin.marinas@arm.com>
    > Cc: Will Deacon <will.deacon@arm.com>
    > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
    > Cc: linux-arm-kernel@lists.infradead.org
    > Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
    > ---
    >
    > arch/arm64/kernel/debug-monitors.c | 6 +++++-
    > 1 file changed, 5 insertions(+), 1 deletion(-)
    >
    > diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c
    > index 636ba8b..959a16b 100644
    > --- a/arch/arm64/kernel/debug-monitors.c
    > +++ b/arch/arm64/kernel/debug-monitors.c
    > @@ -155,12 +155,16 @@ static struct notifier_block os_lock_nb = {
    >
    > static int debug_monitors_init(void)
    > {
    > + cpu_maps_update_begin();
    > +
    > /* Clear the OS lock. */
    > smp_call_function(clear_os_lock, NULL, 1);
    > clear_os_lock(NULL);
    >
    > /* Register hotplug handler. */
    > - register_cpu_notifier(&os_lock_nb);
    > + __register_cpu_notifier(&os_lock_nb);
    > +
    > + cpu_maps_update_done();
    > return 0;
    > }
    > postcore_initcall(debug_monitors_init);

    Acked-by: Will Deacon <will.deacon@arm.com>

    Will


    \
     
     \ /
      Last update: 2014-02-06 13:21    [W:4.032 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site