lkml.org 
[lkml]   [2014]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 16/51] x86, vsyscall: Fix CPU hotplug callback registration
    On 02/11/2014 12:20 AM, Gautham R Shenoy wrote:
    > Hi,
    >
    > On Thu, Feb 06, 2014 at 03:37:27AM +0530, Srivatsa S. Bhat wrote:
    >> @@ -393,9 +393,13 @@ static int __init vsyscall_init(void)
    >> {
    >> BUG_ON(VSYSCALL_ADDR(0) != __fix_to_virt(VSYSCALL_FIRST_PAGE));
    >>
    >> + cpu_maps_update_begin();
    >> +
    >> on_each_cpu(cpu_vsyscall_init, NULL, 1);
    >> /* notifier priority > KVM */
    >> - hotcpu_notifier(cpu_vsyscall_notifier, 30);
    >> + __hotcpu_notifier(cpu_vsyscall_notifier, 30);
    >
    > While we're at it, we could also #define the VSYSCALL_PRIO relative to
    > KVM_PRIO instead of hard-coding the value here, no ?
    >

    Yeah, that sounds like a good idea, but I guess we can do these
    cleanups in a separate patch series.

    >> +
    >> + cpu_maps_update_done();
    >>
    >> return 0;
    >> }
    >>

    Regards,
    Srivatsa S. Bhat



    \
     
     \ /
      Last update: 2014-02-11 08:21    [W:4.202 / U:1.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site