| Date | Mon, 10 Feb 2014 16:53:23 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 19/51] x86, therm_throt.c: Fix CPU hotplug callback registration |
| |
On 02/06, Srivatsa S. Bhat wrote: > > --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c > +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c > @@ -319,7 +319,7 @@ static __init int thermal_throttle_init_device(void) > if (!atomic_read(&therm_throt_en)) > return 0; > > - register_hotcpu_notifier(&thermal_throttle_cpu_notifier); > + cpu_maps_update_begin(); > > #ifdef CONFIG_HOTPLUG_CPU > mutex_lock(&therm_cpu_lock); > @@ -333,6 +333,9 @@ static __init int thermal_throttle_init_device(void) > mutex_unlock(&therm_cpu_lock); > #endif > > + __register_hotcpu_notifier(&thermal_throttle_cpu_notifier); > + cpu_maps_update_done();
Off-topic, but it seems that after this change therm_cpu_lock can die. Of course this needs another patch (if I am right).
Oleg.
|