lkml.org 
[lkml]   [2014]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 42/51] hwmon, coretemp: Fix CPU hotplug callback registration
On Wed, Feb 05, 2014 at 04:44:12PM -0800, Guenter Roeck wrote:
> On Thu, Feb 06, 2014 at 03:42:06AM +0530, Srivatsa S. Bhat wrote:
> > Subsystems that want to register CPU hotplug callbacks, as well as perform
> > initialization for the CPUs that are already online, often do it as shown
> > below:
> >
> > get_online_cpus();
> >
> > for_each_online_cpu(cpu)
> > init_cpu(cpu);
> >
> > register_cpu_notifier(&foobar_cpu_notifier);
> >
> > put_online_cpus();
> >
> > This is wrong, since it is prone to ABBA deadlocks involving the
> > cpu_add_remove_lock and the cpu_hotplug.lock (when running concurrently
> > with CPU hotplug operations).
> >
> > Instead, the correct and race-free way of performing the callback
> > registration is:
> >
> > cpu_maps_update_begin();
> >
> > for_each_online_cpu(cpu)
> > init_cpu(cpu);
> >
> > /* Note the use of the double underscored version of the API */
> > __register_cpu_notifier(&foobar_cpu_notifier);
> >
> > cpu_maps_update_done();
> >
> >
> > Fix the hwmon coretemp code by using this latter form of callback
> > registration.
> >
> > Cc: Fenghua Yu <fenghua.yu@intel.com>
> > Cc: Jean Delvare <jdelvare@suse.de>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: lm-sensors@lm-sensors.org
> > Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
>
> Applied.
>
That obviously doesn't build ;-). Replace with

Acked-by: Guenter Roeck <linux@roeck-us.net>

Guenter


\
 
 \ /
  Last update: 2014-02-06 03:01    [W:0.134 / U:0.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site