lkml.org 
[lkml]   [2013]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 24/35] mfd: ab8500: Remove unnecessary 'struct device' declaration
Date
On Friday 15 February 2013, Lee Jones wrote:
> A recent patch saw the device.h include being removed from some other
> include files and replaced with a 'struct device' declaration instead.
> However, neither the include nor the declaration is actually required.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> include/linux/mfd/abx500.h | 2 --
> 1 file changed, 2 deletions(-)

In my copy of the file, we the declaration


int ab8500_bm_of_probe(struct device *dev,
struct device_node *np,
struct abx500_bm_data *bm);



and others that use 'struct device'. C99 requires that a struct is declared
in advance before you use it in a function declaration.

Arnd


\
 
 \ /
  Last update: 2013-02-25 19:41    [W:0.239 / U:1.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site