Messages in this thread | | | Date | Mon, 25 Feb 2013 14:49:04 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 24/35] mfd: ab8500: Remove unnecessary 'struct device' declaration |
| |
On Mon, 25 Feb 2013, Arnd Bergmann wrote:
> On Friday 15 February 2013, Lee Jones wrote: > > A recent patch saw the device.h include being removed from some other > > include files and replaced with a 'struct device' declaration instead. > > However, neither the include nor the declaration is actually required. > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > include/linux/mfd/abx500.h | 2 -- > > 1 file changed, 2 deletions(-) > > In my copy of the file, we the declaration > > > int ab8500_bm_of_probe(struct device *dev, > struct device_node *np, > struct abx500_bm_data *bm); > > > > and others that use 'struct device'. C99 requires that a struct is declared > in advance before you use it in a function declaration.
Hmm... I wonder why it doesn't complain then?
I'll remove the patch.
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |