Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 24/35] mfd: ab8500: Remove unnecessary 'struct device' declaration | Date | Mon, 25 Feb 2013 16:27:28 +0000 |
| |
On Monday 25 February 2013, Lee Jones wrote: > > and others that use 'struct device'. C99 requires that a struct is declared > > in advance before you use it in a function declaration. > > Hmm... I wonder why it doesn't complain then? > > I'll remove the patch.
It's only a problem if the file is included before any other header declares 'struct device'. It may well be that this currently never happens, but it's better to be safe and have a header that can be included in any order: relying on a specific inclusion order can easily break with 'make randconfig' turning off specific features that you did not know you relied on.
Arnd
| |