On Fri, Feb 15, 2013 at 12:56:33PM +0000, Lee Jones wrote:> + if (gpadc->regu)> + regulator_disable(gpadc->regu);No explanation for this in the changelog and missing error handling likethis is pretty much always terrible style. Why are we doing this?