lkml.org 
[lkml]   [2013]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/35] mfd: ab8500-gpadc: Allow tvout regulator to be missing
    On Fri, Feb 15, 2013 at 12:56:33PM +0000, Lee Jones wrote:

    > + if (gpadc->regu)
    > + regulator_disable(gpadc->regu);

    No explanation for this in the changelog and missing error handling like
    this is pretty much always terrible style. Why are we doing this?


    \
     
     \ /
      Last update: 2013-02-20 15:01    [W:6.937 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site