Messages in this thread Patch in this message | | | From | Lee Jones <> | Subject | [PATCH 33/35] mfd: ab8500-debug: Add explicit dependencies | Date | Fri, 15 Feb 2013 12:57:04 +0000 |
| |
From: Linus Walleij <linus.walleij@stericsson.com>
As I am working on SPARSE_IRQ a number of implicit resource grabs in the kernel become evident. For example, some includes like <linux/irqs.h> would implicitly include <mach/irqs.h> and then from there <mach/db8500-regs.h>.
In many cases it is masking the fact that drivers do not properly use resources to pass their dependencies, base addresses etc. So write explicit #include statements with TODO items to have this fixed the proper way to all drivers doing this.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Philippe LANGLAIS <philippe.langlais@stericsson.com> --- drivers/mfd/ab8500-debugfs.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index b5af8be..37f595d 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -90,6 +90,9 @@ #include <linux/ctype.h> #endif +/* TODO: this file should not reference IRQ_DB8500_AB8500! */ +#include <mach/irqs.h> + static u32 debug_bank; static u32 debug_address; -- 1.7.10.4
| |