lkml.org 
[lkml]   [2023]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 9/9] i2c: designware: Fix spelling and other issues in the comments
Hi Andy,

[...]

> @@ -210,12 +210,12 @@ static void psp_release_i2c_bus(void)
> {
> mutex_lock(&psp_i2c_access_mutex);
>
> - /* Return early if mailbox was malfunctional */
> + /* Return early if mailbox was malfunctioned */

I think "was malfunctioned" is not really correct... maybe "has
malfunctioned"? "is malfunctioning"?

> if (psp_i2c_mbox_fail)
> goto cleanup;

[...]

> @@ -508,7 +510,7 @@ void __i2c_dw_disable(struct dw_i2c_dev *dev)
>
> /*
> * Wait 10 times the signaling period of the highest I2C
> - * transfer supported by the driver (for 400KHz this is
> + * transfer supported by the driver (for 400kHz this is

what did you change here? :)

The rest looks good.

Thanks,
Andi

> * 25us) as described in the DesignWare I2C databook.
> */
> usleep_range(25, 250);

\
 
 \ /
  Last update: 2023-08-04 23:42    [W:0.139 / U:4.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site