Messages in this thread | | | Date | Fri, 28 Jul 2023 15:33:59 +0300 | Subject | Re: [PATCH v1 5/9] i2c: designware: Always provide ID tables | From | Jarkko Nikula <> |
| |
On 7/25/23 17:30, Andy Shevchenko wrote: > There is no need to have ugly ifdeffery and additional macros > for the ID tables. Always provide them. Since we touch the > ACPI table, make it sorted by ID. > > While at it, group MODULE_ALIAS() with other MODULE_*() macros. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/i2c/busses/i2c-designware-platdrv.c | 65 ++++++++++----------- > 1 file changed, 31 insertions(+), 34 deletions(-) > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
(minor comment below if you plan to update)
> +/* Work with hotplug and coldplug */ > +MODULE_ALIAS("platform:i2c_designware");
Perhaps this comment can be retired, i.e. dropped.
| |