Messages in this thread | | | Date | Mon, 7 Aug 2023 17:37:28 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 9/9] i2c: designware: Fix spelling and other issues in the comments |
| |
On Fri, Aug 04, 2023 at 11:41:57PM +0200, Andi Shyti wrote:
...
> > @@ -210,12 +210,12 @@ static void psp_release_i2c_bus(void) > > { > > mutex_lock(&psp_i2c_access_mutex); > > > > - /* Return early if mailbox was malfunctional */ > > + /* Return early if mailbox was malfunctioned */ > > I think "was malfunctioned" is not really correct... maybe "has > malfunctioned"? "is malfunctioning"?
I first stumbled over this, but than I read the function name... I guess they are correct. So I think I need to drop this hunk.
...
> > - * transfer supported by the driver (for 400KHz this is > > + * transfer supported by the driver (for 400kHz this is > > what did you change here? :)
Proper units. k is the official SI prefix for KILO.
-- With Best Regards, Andy Shevchenko
| |