Messages in this thread | | | Date | Wed, 26 Jul 2023 17:48:00 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 3/9] i2c: designware: Align dw_i2c_of_configure() with i2c_dw_acpi_configure() |
| |
On Tue, Jul 25, 2023 at 11:48:36PM +0200, Andi Shyti wrote: > On Tue, Jul 25, 2023 at 05:30:17PM +0300, Andy Shevchenko wrote:
...
> > +static void i2c_dw_of_configure(struct dw_i2c_dev *dev) > > +{ > > + if (dev_of_node(dev->dev)) > > + i2c_dw_of_do_configure(dev, dev->dev); > > You could add this check above and avoid this micro-if-functions. > > if (!dev_of_node(dev->dev)) > return; > > up to you...
Have you had a chance to look into patch 7? Maybe you can come up with some advice or ideas on how to make the series better...
> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Thank you!
> > }
-- With Best Regards, Andy Shevchenko
| |