Messages in this thread | | | Date | Fri, 4 Aug 2023 23:00:55 +0200 | From | Andi Shyti <> | Subject | Re: [PATCH v1 5/9] i2c: designware: Always provide ID tables |
| |
Hi Andy,
On Mon, Jul 31, 2023 at 11:05:05PM +0300, Andy Shevchenko wrote: > On Fri, Jul 28, 2023 at 03:33:59PM +0300, Jarkko Nikula wrote: > > On 7/25/23 17:30, Andy Shevchenko wrote: > > ... > > > > +/* Work with hotplug and coldplug */ > > > +MODULE_ALIAS("platform:i2c_designware"); > > > > Perhaps this comment can be retired, i.e. dropped. > > Then it needs to be done in a separate patch, because in the other file the > comment will be left untouched.
You are being a bit too religios here... if you want to stick to this, then you need to send a patch for sorting by ID, a patch for grouping together MODULE_*, a patch to remove this comment and a patch to always provide the id table.
I think, "while at it", you can safely remove the redundant comment :)
It doesn't make too much difference to me anyway:
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Andi
| |