| Date | Thu, 6 Jul 2023 14:48:01 +0200 | From | Jan Kara <> | Subject | Re: [PATCH v2 50/92] hostfs: convert to ctime accessor functions |
| |
On Wed 05-07-23 15:01:15, Jeff Layton wrote: > In later patches, we're going to change how the inode's ctime field is > used. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Signed-off-by: Jeff Layton <jlayton@kernel.org>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> --- > fs/hostfs/hostfs_kern.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c > index 46387090eb76..182af84a9c12 100644 > --- a/fs/hostfs/hostfs_kern.c > +++ b/fs/hostfs/hostfs_kern.c > @@ -517,8 +517,7 @@ static int hostfs_inode_update(struct inode *ino, const struct hostfs_stat *st) > (struct timespec64){ st->atime.tv_sec, st->atime.tv_nsec }; > ino->i_mtime = > (struct timespec64){ st->mtime.tv_sec, st->mtime.tv_nsec }; > - ino->i_ctime = > - (struct timespec64){ st->ctime.tv_sec, st->ctime.tv_nsec }; > + inode_set_ctime_to_ts(ino, &st->ctime); > ino->i_size = st->size; > ino->i_blocks = st->blocks; > return 0; > -- > 2.41.0 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
|