lkml.org 
[lkml]   [2023]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 44/92] fat: convert to ctime accessor functions
From
Date
On Thu, 2023-07-06 at 10:54 +0900, OGAWA Hirofumi wrote:
> Jeff Layton <jlayton@kernel.org> writes:
>
> > @@ -1407,8 +1407,9 @@ static int fat_read_root(struct inode *inode)
> > MSDOS_I(inode)->mmu_private = inode->i_size;
> >
> > fat_save_attrs(inode, ATTR_DIR);
> > - inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode->i_ctime.tv_sec = 0;
> > - inode->i_mtime.tv_nsec = inode->i_atime.tv_nsec = inode->i_ctime.tv_nsec = 0;
> > + inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode_set_ctime(inode,
> > + 0, 0).tv_sec;
> > + inode->i_mtime.tv_nsec = inode->i_atime.tv_nsec = 0;
>
> Maybe, this should simply be
>
> inode->i_mtime = inode->i_atime = inode_set_ctime(inode, 0, 0);
>

Yes, that would be clearer. Chalk that one up to the automated
coccinelle conversion. I've fixed it in my ctime-next branch.

Thanks!
--
Jeff Layton <jlayton@kernel.org>

\
 
 \ /
  Last update: 2023-07-06 13:26    [W:0.115 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site